Comments on: Refactoring for Testability http://www.testingmentor.com/imtesty/2009/12/02/refactoring-for-testability/ Treatises on the practice of software testing Sat, 03 Jul 2010 11:49:32 -0400 http://wordpress.org/?v=2.9.2 hourly 1 By: testingmentor http://www.testingmentor.com/imtesty/2009/12/02/refactoring-for-testability/comment-page-1/#comment-328 testingmentor Sun, 06 Dec 2009 02:58:43 +0000 http://testingmentor.com/imtesty/2009/12/02/refactoring-for-testability/#comment-328 Hi Chris, I agree that it is generally not a best practice to default to TRUE in a method that returns a Boolean. It is generally 'safer' to initialize to false and make the data prove itself to satisfy whatever condition must be met. But, it ultimately didn't impact control flow in this case, so I didn't bring it up. Thanks for pointing that out. Hi Chris,

I agree that it is generally not a best practice to default to TRUE in a method that returns a Boolean. It is generally ’safer’ to initialize to false and make the data prove itself to satisfy whatever condition must be met. But, it ultimately didn’t impact control flow in this case, so I didn’t bring it up. Thanks for pointing that out.

]]> By: Chris Ahlers http://www.testingmentor.com/imtesty/2009/12/02/refactoring-for-testability/comment-page-1/#comment-326 Chris Ahlers Sat, 05 Dec 2009 12:27:31 +0000 http://testingmentor.com/imtesty/2009/12/02/refactoring-for-testability/#comment-326 Something else that I see in this code example that is problematic is the fact that "isOk" is defaulted to TRUE. Data validation functions like this one should always assume the data is bad/corrupt. Hence, "isOk" should be initialized to FALSE. Only after the data has been verified as being good should "isOk" be set to TRUE. Something else that I see in this code example that is problematic is the fact that “isOk” is defaulted to TRUE. Data validation functions like this one should always assume the data is bad/corrupt. Hence, “isOk” should be initialized to FALSE. Only after the data has been verified as being good should “isOk” be set to TRUE.

]]> By: Refactoring for Testability « Test Infected http://www.testingmentor.com/imtesty/2009/12/02/refactoring-for-testability/comment-page-1/#comment-324 Refactoring for Testability « Test Infected Thu, 03 Dec 2009 13:32:27 +0000 http://testingmentor.com/imtesty/2009/12/02/refactoring-for-testability/#comment-324 [...] Discussion — Tags: Link — wanderleisouza @ 11:32 am Refactoring for Testability at http://testingmentor.com/imtesty/2009/12/02/refactoring-for-testability/ Leave a [...] [...] Discussion — Tags: Link — wanderleisouza @ 11:32 am Refactoring for Testability at http://testingmentor.com/imtesty/2009/12/02/refactoring-for-testability/ Leave a [...]

]]>